feat: add "display_order" column to coder_parameter to keep parameters sorted in UI #8227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mafredri
approved these changes
Jun 30, 2023
| @@ -0,0 +1,4 @@ | |||
| ALTER TABLE template_version_parameters ADD COLUMN display_order integer NOT NULL DEFAULT 0; | |||
There was a problem hiding this comment.
It's possible to use a reserved word as a name via quoting, e.g. ADD COLUMN "order", but I prefer this approach 👍🏻.
| ) RETURNING *; | ||
|
|
||
| -- name: GetTemplateVersionParameters :many | ||
| SELECT * FROM template_version_parameters WHERE template_version_id = $1; | ||
| SELECT * FROM template_version_parameters WHERE template_version_id = $1 ORDER BY display_order ASC, LOWER(name) ASC; |
There was a problem hiding this comment.
Thanks for using explicit ASC, helps to convey the intent.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8193
This PR implements the "display_order" db column (
ORDERis a reserved word), which is used to ensure the order of parameters based on thecoder_parameterTF property.