Skip to content

fix(cli/agent): wrap lumberjack logger to prevent re-open #8229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix(cli/agent): wrap lumberjack logger to prevent re-open #8229

merged 1 commit into from
Jun 27, 2023

Conversation

mafredri
Copy link
Member

This was resulting in CI flakes so I wrapped the other lumberjack logger as well and renamed it to raise awareness.

@mafredri mafredri requested a review from mtojek June 27, 2023 11:51
@mafredri mafredri changed the title fix(cli/agent): wrap lumberjack logger to fix close fix(cli/agent): wrap lumberjack logger to prevent re-open Jun 27, 2023
mtojek
mtojek approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could mark it as hotfix :)

@mafredri mafredri added the hotfix PRs only. Harmless small change. Only humans may set this. label Jun 27, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Jun 27, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@mafredri mafredri enabled auto-merge (squash) June 27, 2023 12:48
@mafredri mafredri merged commit b4751c7 into main Jun 27, 2023
@mafredri mafredri deleted the mafredri/fix-cli-agent-log-close branch June 27, 2023 12:49
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@mafredri mafredri

Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @mtojek