Skip to content

fix: Remove line length limit on MacOS for input prompts #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Conversation

kylecarbs
Copy link
Member

This caused inputs to be truncated on MacOS terminals.

@kylecarbs kylecarbs requested a review from coadler April 3, 2022 17:32
@kylecarbs kylecarbs self-assigned this Apr 3, 2022
@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #839 (d7fbb1a) into main (2a7ab08) will decrease coverage by 0.26%.
The diff coverage is 3.33%.

@@            Coverage Diff             @@
##             main     #839      +/-   ##
==========================================
- Coverage   65.86%   65.60%   -0.27%     
==========================================
  Files         200      202       +2     
  Lines       13179    13209      +30     
  Branches       87       87              
==========================================
- Hits         8681     8666      -15     
- Misses       3607     3649      +42     
- Partials      891      894       +3     
Flag Coverage Δ
unittest-go- 65.07% <9.09%> (-0.23%) ⬇️
unittest-go-macos-latest 52.37% <3.57%> (-0.09%) ⬇️
unittest-go-ubuntu-latest 54.94% <9.09%> (-0.18%) ⬇️
unittest-go-windows-2022 51.73% <9.09%> (+0.01%) ⬆️
unittest-js 62.63% <ø> (ø)
Impacted Files Coverage Δ
cli/cliui/cliui_darwin.go 0.00% <0.00%> (ø)
cli/cliui/cliui_other.go 0.00% <0.00%> (ø)
cli/cliui/prompt.go 71.60% <11.11%> (-7.57%) ⬇️
peer/conn.go 77.66% <0.00%> (-2.80%) ⬇️
provisioner/echo/serve.go 54.40% <0.00%> (-2.40%) ⬇️
provisionerd/provisionerd.go 77.97% <0.00%> (-1.18%) ⬇️
coderd/provisionerdaemons.go 60.03% <0.00%> (-0.51%) ⬇️
peer/channel.go 83.62% <0.00%> (+0.58%) ⬆️
coderd/workspaceresources.go 59.34% <0.00%> (+3.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a7ab08...d7fbb1a. Read the comment docs.

@kylecarbs kylecarbs force-pushed the macterm branch 2 times, most recently from e498821 to 4e87001 Compare April 3, 2022 17:40
This caused inputs to be truncated on MacOS terminals.
@kylecarbs kylecarbs enabled auto-merge (squash) April 3, 2022 18:08
@kylecarbs kylecarbs merged commit ccba2ba into main Apr 3, 2022
@kylecarbs kylecarbs deleted the macterm branch April 3, 2022 18:09
spikecurtis added a commit that referenced this pull request May 10, 2022
Revert "fix: Remove line length limit on MacOS for input prompts (#839)"

This reverts commit ccba2ba.
spikecurtis added a commit that referenced this pull request May 10, 2022
Revert "fix: Remove line length limit on MacOS for input prompts (#839)"

This reverts commit ccba2ba.
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
Revert "fix: Remove line length limit on MacOS for input prompts (#839)"

This reverts commit ccba2ba.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants