chore: enable exhaustruct linter #8403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
commented
Jul 11, 2023
| @@ -527,6 +527,7 @@ distro() { | |||
|
|
|||
| if [ -f /etc/os-release ]; then | |||
| ( | |||
| # shellcheck disable=SC1091 | |||
There was a problem hiding this comment.
review: this was making lint fail locally on darwin
mafredri
approved these changes
Jul 11, 2023
Emyrk
approved these changes
Jul 11, 2023
| @@ -390,6 +390,7 @@ func New(options *Options) *API { | |||
| RedirectToLogin: false, | |||
| DisableSessionExpiryRefresh: options.DeploymentValues.DisableSessionExpiryRefresh.Value(), | |||
| Optional: false, | |||
| SessionTokenFunc: nil, // Default behavior | |||
There was a problem hiding this comment.
Do we need to have the // Default behavior comment?
The comment on the field says: If nil, the default behavior is used.
There was a problem hiding this comment.
We don't need the comment, I was just being super explicit about what it means.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just enabling on
httpmw\.\w+for now. We can add coverage as we go.