Skip to content

chore(scripts): use slim and always run make in coder-dev.sh #8418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 13, 2023
Merged

chore(scripts): use slim and always run make in coder-dev.sh #8418

merged 3 commits into from
Jul 13, 2023

Conversation

mafredri
Copy link
Member

When developing, it's hard to keep track of if the coder client is up-to-date when making local changes and running the server via scripts/develop.sh. This changes scripts/coder-dev.sh such that it no longer uses the full (fat) binary and instead performs a make each time, ensuring the slim binary is up-to-date.

This change has the repercussion that if there are changes, running it can take a long time (make generate, etc).

Otherwise, the overhead of using make is quite small:

❯ time make build/coder-slim_linux_amd64
make build/coder-slim_linux_amd64  0.32s user 0.10s system 92% cpu 0.450 total

@mtojek mtojek self-requested a review July 11, 2023 11:54
@mafredri mafredri force-pushed the mafredri/chore-improve-coder-dev-script branch from 6a90300 to 1ff3bc7 Compare July 11, 2023 11:54
mtojek
mtojek approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate this contribution, but you may want to confirm it with other devs. 👍

johnstcn
johnstcn approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I say aye

@mafredri
Copy link
Member Author

I realized this PR would break one of my own workflows, where I quickly drop into the local database via:

psql $(./scripts/coder-dev.sh server postgres-builtin-url --raw-url)

So I added back support for coder server, with a caveat. It's not ideal since the behavior is kind of strange, but makes kinda sense when thinking about the develop.sh requirement.

See: 36a0300 (#8418)

Thoughts @mtojek @johnstcn?

@mafredri mafredri merged commit 70047ff into main Jul 13, 2023
@mafredri mafredri deleted the mafredri/chore-improve-coder-dev-script branch July 13, 2023 08:51
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@mtojek mtojek mtojek approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mafredri @johnstcn @mtojek