Skip to content

fix(site): paginate audit logs #8513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2023
Merged

fix(site): paginate audit logs #8513

merged 2 commits into from
Jul 14, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jul 14, 2023

Fixes: #7995

This PR aligns the pagination used by the site with the API endpoint.

The "offset" is the number of records skipped, not the page number. When the site requested the first page with offset=1, actually it skipped the first record.

@mtojek mtojek self-assigned this Jul 14, 2023
@mtojek mtojek requested a review from BrunoQuaresma July 14, 2023 09:27
@mtojek mtojek marked this pull request as ready for review July 14, 2023 09:27
@mtojek mtojek merged commit b7806fd into main Jul 14, 2023
@mtojek mtojek deleted the 7995-audit-start branch July 14, 2023 10:24
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Workspace starts, but not recorded in audit logs
2 participants