Skip to content

test: Fix ProjectVersionLogs returning error when using DB #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2022
Merged

test: Fix ProjectVersionLogs returning error when using DB #852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: Fix ProjectVersionLogs returning error when using DB 
This didn't actually effect the test value, since we're just looking for
logs. It did produce spam in the logs though, and could be interpreted
as a failure.
  • Loading branch information
@kylecarbs
kylecarbs committed Apr 4, 2022
commit 33094abc04cafad43eb2ab3ca3ef1ce16b8127c6
3 changes: 2 additions & 1 deletion coderd/projectversions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,8 @@ func TestProjectVersionLogs(t *testing.T) {
coderdtest.NewProvisionerDaemon(t, client)
before := time.Now()
version := coderdtest.CreateProjectVersion(t, client, user.OrganizationID, &echo.Responses{
Parse: echo.ParseComplete,
Parse: echo.ParseComplete,
ProvisionDryRun: echo.ProvisionComplete,
Provision: []*proto.Provision_Response{{
Type: &proto.Provision_Response_Log{
Log: &proto.Log{
Expand Down