Skip to content

chore: add filebrowser to dogfood #8535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 18, 2023
Merged

Conversation

matifali
Copy link
Member

@matifali matifali commented Jul 16, 2023

Adds https://github.com/filebrowser/filebrowser to dogfood template.

Screenshot

image

Apparently, it isn't working on the subpath and I had to use subdomain=true

Apparently it isn't working on subpath and I had to use `subdomain=true`
@matifali matifali requested a review from bpmct July 16, 2023 08:52
@matifali matifali requested a review from kylecarbs July 16, 2023 09:02
When the directory was set to `/home/coder/coder`,
`startup_script` installs everything in the specified directory. As `/home/coder/coder` is a git repo so git complains about unstaged files and either we have to dlete those files to populate in .gitignore.
slug = "filebrowser"
url = "http://localhost:8080/"
icon = "https://raw.githubusercontent.com/matifali/logos/main/database.svg"
subdomain = true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to use it without subdomain=true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be possible, following this approach and I was able to start it on a subpath with a minor issue. (somehow coder repeats app path 2 times)

@matifali matifali requested a review from mafredri July 18, 2023 09:49
@matifali matifali requested a review from mafredri July 18, 2023 13:17
@matifali matifali merged commit 9e170a7 into main Jul 18, 2023
@matifali matifali deleted the matifali/dogfood-filerowser branch July 18, 2023 14:04
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants