Skip to content

fix(cli/delete): prompt for confirmation after workspace is found #8579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2023
Merged

fix(cli/delete): prompt for confirmation after workspace is found #8579

merged 1 commit into from
Aug 5, 2023

Conversation

ammario
Copy link
Member

@ammario ammario commented Jul 18, 2023 •
edited
Loading

fix(cli/delete): prompt for confirmation after workspace is found

@ammario ammario added the hotfix label Jul 18, 2023
@ammario ammario self-assigned this Jul 18, 2023
@ammario ammario enabled auto-merge (squash) July 18, 2023 16:46
cdr-bot[bot]
cdr-bot bot previously approved these changes Jul 18, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is no longer a hotfix.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ❌ Less than 100 lines

@matifali
Copy link
Member

matifali commented Jul 23, 2023 •
edited
Loading

It looks like one of the tests are failing after the change.

@cdr-bot cdr-bot bot dismissed their stale review July 25, 2023 14:34

This PR is no longer a hotfix.

@ammario ammario changed the title fix(cli/delete): prompt confirmation after workspace found fix(cli/delete): prompt for confirmation after workspace is found Jul 25, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Jul 25, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@ammario ammario disabled auto-merge July 25, 2023 14:36
@ammario ammario enabled auto-merge (squash) July 25, 2023 14:36
@github-actions github-actions bot added the stale This issue is like stale bread. label Aug 2, 2023
@github-actions github-actions bot closed this Aug 5, 2023
auto-merge was automatically disabled August 5, 2023 00:10

Pull request was closed

@matifali matifali reopened this Aug 5, 2023
@matifali matifali enabled auto-merge (squash) August 5, 2023 05:35
@matifali matifali disabled auto-merge August 5, 2023 05:36
@matifali
Copy link
Member

matifali commented Aug 5, 2023

@ammario will this allow force deleting with a -y or --yes

@matifali matifali removed the stale This issue is like stale bread. label Aug 5, 2023
@ammario
Copy link
Member Author

ammario commented Aug 5, 2023

If it did before, this PR wouldn't change the behavior.

@ammario ammario merged commit 81752d1 into main Aug 5, 2023
@ammario ammario deleted the fix-rm branch August 5, 2023 16:25
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@ammario ammario

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ammario @matifali