Skip to content

ci: fix release notes compare link #8581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2023
Merged

ci: fix release notes compare link #8581

merged 2 commits into from
Jul 21, 2023

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Jul 18, 2023

Didn't really want to break anything but let me know if there's a better way to do this.

@bpmct bpmct requested a review from mafredri July 18, 2023 17:57
@mafredri
Copy link
Member

@bpmct Nice catch! Looks like this is actually a bug in release.yaml. We should do e.g. version="v$(./scripts/version.sh)" instead of version="$(./scripts/version.sh)".

Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed an alternate fix 👍🏻

@mafredri mafredri changed the title chore: fix release notes compare link ci: fix release notes compare link Jul 21, 2023
@mafredri mafredri merged commit 12b51ca into main Jul 21, 2023
@mafredri mafredri deleted the bpmct/fix-releaselink branch July 21, 2023 12:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2023
@mafredri
Copy link
Member

@bpmct went ahead and merged this so it'll be fixed in the next release 👍🏻

@bpmct
Copy link
Member Author

bpmct commented Jul 21, 2023

Thanks!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants