Skip to content

test(coderd): fix TestWorkspaceWatcher flake #8612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2023
Merged

test(coderd): fix TestWorkspaceWatcher flake #8612

merged 1 commit into from
Jul 19, 2023

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Jul 19, 2023

A previous PR removed the provisioner close, causing the cancel to race with the build completing.

@coadler
test(coderd): fix TestWorkspaceWatcher flake
75055ab 
A previous PR removed the provisioner close, causing the cancel to race
with the build completing.
@coadler coadler self-assigned this Jul 19, 2023
@coadler coadler added the hotfix label Jul 19, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Jul 19, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@coadler coadler merged commit 3988917 into main Jul 19, 2023
@coadler coadler deleted the colin/workspacewatch-flake branch July 19, 2023 23:03
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@coadler