From d4b8dfac4ac9389e213a2c23b48f8a1fa6c05582 Mon Sep 17 00:00:00 2001 From: Muhammad Atif Ali Date: Thu, 20 Jul 2023 18:26:13 +0300 Subject: [PATCH] chore: allow running other jobs in the matrix if one of them fails I have observed a https://github.com/coder/coder/actions/runs/5612329012/job/15206182379 was cancelled berceuse of a macOS test-go failed. This will allow keep other jobs running in the matrix. GitHub now allows only https://docs.github.com/en/actions/managing-workflow-runs/re-running-workflows-and-jobs#re-running-failed-jobs-in-a-workflow so it will save us some runner minutes given we have flaky tests. Reference: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#handling-failures --- .github/workflows/ci.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 1649e4f5cd920..dec9fd9b5ff89 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -240,6 +240,7 @@ jobs: if: needs.changes.outputs.go == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main' timeout-minutes: 20 strategy: + fail-fast: false matrix: os: - ubuntu-latest