Skip to content

docs: add coder-logstream-kube docs and update k8s example template #8675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Jul 24, 2023
Merged

docs: add coder-logstream-kube docs and update k8s example template #8675

merged 26 commits into from
Jul 24, 2023

Conversation

matifali
Copy link
Member

Resolves #8549

@matifali matifali marked this pull request as draft July 23, 2023 14:33
@coder coder deleted a comment from github-actions bot Jul 23, 2023
@coder coder deleted a comment from github-actions bot Jul 23, 2023
@coder coder deleted a comment from github-actions bot Jul 23, 2023
@coder coder deleted a comment from github-actions bot Jul 23, 2023
@matifali
Copy link
Member Author

/deploy-pr

@github-actions
Copy link

github-actions bot commented Jul 23, 2023 •
edited
Loading

✔️ Deployed PR 8675 successfully.
🚀 Access the deployment link here.
⚠️ This deployment will be deleted when the PR is closed.

@matifali matifali changed the title docs: add Coder logstream-kube docs and update k8s example template docs: add coder-logstream-kube docs and update k8s example template Jul 23, 2023
@matifali matifali marked this pull request as ready for review July 23, 2023 18:04
@matifali matifali requested a review from bpmct July 23, 2023 18:04
@matifali matifali requested a review from ericpaulsen July 24, 2023 11:53
bpmct
bpmct reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome docs! Love the detail. Besides minor feedback, the copy LGTM. Let's wait on merging so that we can also change the default behavior of Helm to avoid extra steps/confusion for users.

@matifali matifali requested a review from bpmct July 24, 2023 14:46
@ericpaulsen ericpaulsen merged commit 6929792 into main Jul 24, 2023
@ericpaulsen ericpaulsen deleted the matifali/kubestream-docs branch July 24, 2023 15:51
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericpaulsen ericpaulsen ericpaulsen approved these changes

@bpmct bpmct Awaiting requested review from bpmct

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document coder-logstream-kube
3 participants
@matifali @ericpaulsen @bpmct