From 201122e2d3e36743e5fc59f2e556a1e635e417a8 Mon Sep 17 00:00:00 2001 From: Muhammad Atif Ali Date: Sun, 23 Jul 2023 18:50:45 +0300 Subject: [PATCH 1/3] chore: improve deploy-pr.yaml --- .github/workflows/pr-deploy.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pr-deploy.yaml b/.github/workflows/pr-deploy.yaml index 5e6fde47fea1b..a7552138fb44d 100644 --- a/.github/workflows/pr-deploy.yaml +++ b/.github/workflows/pr-deploy.yaml @@ -2,6 +2,7 @@ name: Deploy PR on: issue_comment: + types: [created, edited] workflow_dispatch: inputs: pr_number: From 13188e7be424f96810e7769f51f1c5769d5373d2 Mon Sep 17 00:00:00 2001 From: Muhammad Atif Ali Date: Sun, 23 Jul 2023 18:58:21 +0300 Subject: [PATCH 2/3] Update pr-deploy.yaml --- .github/workflows/pr-deploy.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-deploy.yaml b/.github/workflows/pr-deploy.yaml index a7552138fb44d..e0ba6334a4e99 100644 --- a/.github/workflows/pr-deploy.yaml +++ b/.github/workflows/pr-deploy.yaml @@ -144,14 +144,14 @@ jobs: mkdir -p ~/.kube echo "${{ secrets.DELIVERYBOT_KUBECONFIG }}" > ~/.kube/config export KUBECONFIG=~/.kube/config - + - name: Create PR namespace run: | set -euxo pipefail # try to delete the namespace, but don't fail if it doesn't exist kubectl delete namespace "pr${{ env.PR_NUMBER }}" || true kubectl create namespace "pr${{ env.PR_NUMBER }}" - + - name: Install Helm chart run: | helm upgrade --install pr${{ env.PR_NUMBER }} ./helm \ From ada950d496d9dbb3a227d52fcb5b3ed54dd687a9 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Sun, 23 Jul 2023 16:02:40 +0000 Subject: [PATCH 3/3] make fmt --- .github/workflows/pr-deploy.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-deploy.yaml b/.github/workflows/pr-deploy.yaml index e0ba6334a4e99..a7552138fb44d 100644 --- a/.github/workflows/pr-deploy.yaml +++ b/.github/workflows/pr-deploy.yaml @@ -144,14 +144,14 @@ jobs: mkdir -p ~/.kube echo "${{ secrets.DELIVERYBOT_KUBECONFIG }}" > ~/.kube/config export KUBECONFIG=~/.kube/config - + - name: Create PR namespace run: | set -euxo pipefail # try to delete the namespace, but don't fail if it doesn't exist kubectl delete namespace "pr${{ env.PR_NUMBER }}" || true kubectl create namespace "pr${{ env.PR_NUMBER }}" - + - name: Install Helm chart run: | helm upgrade --install pr${{ env.PR_NUMBER }} ./helm \