From fafa8609bdcd4431fb8eecb22218fbad4f3997b5 Mon Sep 17 00:00:00 2001 From: Muhammad Atif Ali Date: Wed, 26 Jul 2023 03:27:18 +0300 Subject: [PATCH 1/2] ci: add a missing end quote --- .github/workflows/pr-deploy.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-deploy.yaml b/.github/workflows/pr-deploy.yaml index 52754440a4643..62aa8ec8b2974 100644 --- a/.github/workflows/pr-deploy.yaml +++ b/.github/workflows/pr-deploy.yaml @@ -214,7 +214,7 @@ jobs: "pr_number": "'"${{ env.PR_NUMBER }}"'", "pr_url": "'"${{ env.PR_URL }}"'", "pr_title": "'"${{ env.PR_TITLE }}"'", - "pr_access_url": "'"${{ env.PR_DEPLOYMENT_ACCESS_URL }}'" }' ${{ secrets.PR_DEPLOYMENTS_SLACK_WEBHOOK }} + "pr_access_url": "'"${{ env.PR_DEPLOYMENT_ACCESS_URL }}"'" }' ${{ secrets.PR_DEPLOYMENTS_SLACK_WEBHOOK }} echo "Slack notification sent" env: PR_DEPLOYMENT_ACCESS_URL: "https://pr${{ env.PR_NUMBER }}.${{ secrets.PR_DEPLOYMENTS_DOMAIN }}" From bd0d827136d2d0052ca3750463acac03442e0389 Mon Sep 17 00:00:00 2001 From: Muhammad Atif Ali Date: Wed, 26 Jul 2023 03:35:26 +0300 Subject: [PATCH 2/2] include https for CODER_ACCESS_URL --- .github/workflows/pr-deploy.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-deploy.yaml b/.github/workflows/pr-deploy.yaml index 62aa8ec8b2974..ee4d274341e3f 100644 --- a/.github/workflows/pr-deploy.yaml +++ b/.github/workflows/pr-deploy.yaml @@ -182,7 +182,7 @@ jobs: --set coder.service.type=ClusterIP \ --set coder.serviceAccount.enableDeployments=true \ --set coder.env[0].name=CODER_ACCESS_URL \ - --set coder.env[0].value="pr${{ env.PR_NUMBER }}.${{ secrets.PR_DEPLOYMENTS_DOMAIN }}" \ + --set coder.env[0].value="https://pr${{ env.PR_NUMBER }}.${{ secrets.PR_DEPLOYMENTS_DOMAIN }}" \ --set coder.env[1].name=CODER_WILDCARD_ACCESS_URL \ --set coder.env[1].value="*--pr${{ env.PR_NUMBER }}.${{ secrets.PR_DEPLOYMENTS_DOMAIN }}" \ --set coder.env[2].name=CODER_EXPERIMENTS \