From 2d69ca3fedc3cdf07cf578e10b208b719d764013 Mon Sep 17 00:00:00 2001 From: Colin Adler Date: Thu, 27 Jul 2023 03:20:21 +0000 Subject: [PATCH] fix(codersdk): always dial agents with `WorkspaceAgentIP` --- codersdk/workspaceagents.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/codersdk/workspaceagents.go b/codersdk/workspaceagents.go index 994f32026b61a..b250f3a98e1a9 100644 --- a/codersdk/workspaceagents.go +++ b/codersdk/workspaceagents.go @@ -397,6 +397,11 @@ func (c *Client) DialWorkspaceAgent(ctx context.Context, agentID uuid.UUID, opti agentConn = NewWorkspaceAgentConn(conn, WorkspaceAgentConnOptions{ AgentID: agentID, + // Newer agents will listen on two IPs: WorkspaceAgentIP and an IP + // derived from the agents UUID. We need to use the legacy + // WorkspaceAgentIP here since we don't know if the agent is listening + // on the new IP. + AgentIP: WorkspaceAgentIP, CloseFunc: func() error { cancel() <-closedCoordinator