Skip to content

ci: further improve pr deployments #8764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 27, 2023
Merged

ci: further improve pr deployments #8764

merged 9 commits into from
Jul 27, 2023

Conversation

matifali
Copy link
Member

@matifali matifali commented Jul 27, 2023 •
edited
Loading

We clean up the namespace and the image tag whenever the PR is closed/merged.
IF we want to support deploying any branch or main without an open PR, this makes the clean up process tedious.

This PR.

  1. Remove the ability to deploy the main to help clean up.
  2. Adds confirmation and dry-run to ./secripts/deploy-pr.sh

@matifali matifali changed the title ci: remove the ability ro deploy main to help clean up ci: remove the ability to deploy main to help clean up Jul 27, 2023
@matifali matifali changed the title ci: remove the ability to deploy main to help clean up ci: further improve pr deployments Jul 27, 2023
@matifali matifali requested a review from bpmct July 27, 2023 12:19
cdr-bot[bot]
cdr-bot bot approved these changes Jul 27, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@matifali matifali enabled auto-merge (squash) July 27, 2023 12:37
@matifali matifali merged commit 3761205 into main Jul 27, 2023
@matifali matifali deleted the improve-cleanup branch July 27, 2023 12:41
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

@bpmct bpmct Awaiting requested review from bpmct

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matifali