From 0e151c33af08711367fbd322bfdf84b7c1004449 Mon Sep 17 00:00:00 2001 From: BrunoQuaresma Date: Wed, 2 Aug 2023 14:22:20 +0000 Subject: [PATCH] fix(site): fix initial value for update parameters --- .../WorkspacePage/UpdateBuildParametersDialog.tsx | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/site/src/pages/WorkspacePage/UpdateBuildParametersDialog.tsx b/site/src/pages/WorkspacePage/UpdateBuildParametersDialog.tsx index d32ca006df9d1..33d42b6bc5ae2 100644 --- a/site/src/pages/WorkspacePage/UpdateBuildParametersDialog.tsx +++ b/site/src/pages/WorkspacePage/UpdateBuildParametersDialog.tsx @@ -16,6 +16,7 @@ import { useFormik } from "formik" import { selectInitialRichParametersValues, useValidationSchemaForRichParameters, + workspaceBuildParameterValue, } from "utils/richParameters" import * as Yup from "yup" import DialogActions from "@mui/material/DialogActions" @@ -32,10 +33,11 @@ export const UpdateBuildParametersDialog: FC< UpdateBuildParametersDialogProps > = ({ missedParameters, onUpdate, ...dialogProps }) => { const styles = useStyles() + const initialRichParameterValues = + selectInitialRichParametersValues(missedParameters) const form = useFormik({ initialValues: { - rich_parameter_values: - selectInitialRichParametersValues(missedParameters), + rich_parameter_values: initialRichParameterValues, }, validationSchema: Yup.object({ rich_parameter_values: useValidationSchemaForRichParameters( @@ -81,9 +83,12 @@ export const UpdateBuildParametersDialog: FC< {...getFieldHelpers( "rich_parameter_values[" + index + "].value", )} + initialValue={workspaceBuildParameterValue( + initialRichParameterValues, + parameter, + )} key={parameter.name} parameter={parameter} - initialValue="" index={index} onChange={async (value) => { await form.setFieldValue(