From 1c8f14d3b16a9edea42ce39f362708726cb75e6b Mon Sep 17 00:00:00 2001
From: Kyle Carberry <kyle@carberry.com>
Date: Tue, 8 Aug 2023 05:24:50 +0000
Subject: [PATCH 1/2] chore: add e2e test for backwards client ssh
 compatibility

This was discussed as part of our regression review for outdated
agents, so here is the reverse with an extremely old client.
---
 site/e2e/helpers.ts                |  6 ++--
 site/e2e/tests/outdatedCLI.spec.ts | 52 ++++++++++++++++++++++++++++++
 2 files changed, 56 insertions(+), 2 deletions(-)
 create mode 100644 site/e2e/tests/outdatedCLI.spec.ts

diff --git a/site/e2e/helpers.ts b/site/e2e/helpers.ts
index dfbd5f99896a2..95dd12136c8bd 100644
--- a/site/e2e/helpers.ts
+++ b/site/e2e/helpers.ts
@@ -65,12 +65,14 @@ export const createTemplate = async (
 export const sshIntoWorkspace = async (
   page: Page,
   workspace: string,
+  binaryPath = "go",
+  binaryArgs = ["run", coderMainPath()],
 ): Promise<ssh.Client> => {
   const sessionToken = await findSessionToken(page)
   return new Promise<ssh.Client>((resolve, reject) => {
     const cp = spawn(
-      "go",
-      ["run", coderMainPath(), "ssh", "--stdio", workspace],
+      binaryPath,
+      [...binaryArgs, "ssh", "--stdio", workspace],
       {
         env: {
           ...process.env,
diff --git a/site/e2e/tests/outdatedCLI.spec.ts b/site/e2e/tests/outdatedCLI.spec.ts
new file mode 100644
index 0000000000000..ab143bad27c34
--- /dev/null
+++ b/site/e2e/tests/outdatedCLI.spec.ts
@@ -0,0 +1,52 @@
+import { test } from "@playwright/test"
+import { randomUUID } from "crypto"
+import {
+  createTemplate,
+  createWorkspace,
+  downloadCoderVersion,
+  sshIntoWorkspace,
+  startAgent,
+} from "../helpers"
+
+const clientVersion = "v0.14.0"
+
+test("ssh with client " + clientVersion, async ({ page }) => {
+  const token = randomUUID()
+  const template = await createTemplate(page, {
+    apply: [
+      {
+        complete: {
+          resources: [
+            {
+              agents: [
+                {
+                  token,
+                },
+              ],
+            },
+          ],
+        },
+      },
+    ],
+  })
+  const workspace = await createWorkspace(page, template)
+  await startAgent(page, token)
+  const binaryPath = await downloadCoderVersion(clientVersion)
+
+  const client = await sshIntoWorkspace(page, workspace, binaryPath)
+  await new Promise<void>((resolve, reject) => {
+    // We just exec a command to be certain the agent is running!
+    client.exec("exit 0", (err, stream) => {
+      if (err) {
+        return reject(err)
+      }
+      stream.on("exit", (code) => {
+        if (code !== 0) {
+          return reject(new Error(`Command exited with code ${code}`))
+        }
+        client.end()
+        resolve()
+      })
+    })
+  })
+})

From 7809dafb79edf017f19e3db1f6c5dae058cbe72a Mon Sep 17 00:00:00 2001
From: Kyle Carberry <kyle@carberry.com>
Date: Tue, 8 Aug 2023 05:33:26 +0000
Subject: [PATCH 2/2] fmt

---
 site/e2e/helpers.ts | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/site/e2e/helpers.ts b/site/e2e/helpers.ts
index 95dd12136c8bd..b86a7c756f3a8 100644
--- a/site/e2e/helpers.ts
+++ b/site/e2e/helpers.ts
@@ -70,17 +70,13 @@ export const sshIntoWorkspace = async (
 ): Promise<ssh.Client> => {
   const sessionToken = await findSessionToken(page)
   return new Promise<ssh.Client>((resolve, reject) => {
-    const cp = spawn(
-      binaryPath,
-      [...binaryArgs, "ssh", "--stdio", workspace],
-      {
-        env: {
-          ...process.env,
-          CODER_SESSION_TOKEN: sessionToken,
-          CODER_URL: "http://localhost:3000",
-        },
+    const cp = spawn(binaryPath, [...binaryArgs, "ssh", "--stdio", workspace], {
+      env: {
+        ...process.env,
+        CODER_SESSION_TOKEN: sessionToken,
+        CODER_URL: "http://localhost:3000",
       },
-    )
+    })
     cp.on("error", (err) => reject(err))
     const proxyStream = new Duplex({
       read: (size) => {