Skip to content

chore: cleanup extraneous logging #9156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2023
Merged

chore: cleanup extraneous logging #9156

merged 1 commit into from
Aug 17, 2023

Conversation

ammario
Copy link
Member

@ammario ammario commented Aug 17, 2023

chore: cleanup extraneous logging

  • The batchstats warning went out on every Ctrl+C in my development

Rule of silence:

The provisioner and connect messages messages were sent out on every startup
without a corresponding user event, making them annoying and more-so
debug messages.

@ammario ammario enabled auto-merge (squash) August 17, 2023 20:36
@ammario ammario requested a review from mafredri August 17, 2023 20:36
* The batchstats warning went out on every Ctrl+C in my development

Rule of silence:

The provisioner and connect messages messages were sent out on every startup
without a corresponding user event, making them annoying and more-so
debug messages.
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, this had been catching my eye as well!

@ammario ammario merged commit be40dc8 into main Aug 17, 2023
@ammario ammario deleted the pr9156 branch August 17, 2023 21:01
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants