Skip to content

fix(site): render variable width unicode characters in terminal #9259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2023
Merged

fix(site): render variable width unicode characters in terminal #9259

merged 1 commit into from
Aug 25, 2023

Conversation

ammario
Copy link
Member

@ammario ammario commented Aug 23, 2023 •
edited
Loading

fix(site): render variable width unicode characters in terminal

Previously, characters such as 🟢 were given insufficient space, leading
to mangled output.

Stack created with Sapling. Best reviewed with ReviewStack.

@ammario
fix(site): render variable width unicode characters in terminal
8121e4f 
Previously, characters such as 🟢 were given insufficient space, leading
to mangled output.
@ammario ammario requested a review from code-asher August 23, 2023 00:55
@ammario ammario enabled auto-merge (squash) August 23, 2023 00:55
@ammario ammario mentioned this pull request Aug 24, 2023
Merged
@ammario ammario added the hotfix PRs only. Harmless small change. Only humans may set this. label Aug 25, 2023
@ammario ammario merged commit e5c64a8 into main Aug 25, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Aug 25, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@ammario ammario deleted the pr9259 branch August 25, 2023 17:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

@code-asher code-asher Awaiting requested review from code-asher

Assignees

@ammario ammario

Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ammario