-
Notifications
You must be signed in to change notification settings - Fork 896
docs: expand on TTL flags #9286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@deansheather can you review? want to make sure all of these flags are active |
Hi @ericpaulsen these are auto generated docs and will be overwritten when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update the respective go files in CLI directory and then do make gen
and make update-golden-files
I've run the make
commands requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but can you revet changes to type script files?
this PR adds color to the documentation for our various TTL flags, and where they map to in the UI. the flags in question:
--default-ttl
--max-ttl
--failure-ttl
--inactivity-ttl