Skip to content

docs: expand on TTL flags #9286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 25, 2023
Merged

docs: expand on TTL flags #9286

merged 5 commits into from
Aug 25, 2023

Conversation

ericpaulsen
Copy link
Member

this PR adds color to the documentation for our various TTL flags, and where they map to in the UI. the flags in question:

  • --default-ttl
  • --max-ttl
  • --failure-ttl
  • --inactivity-ttl

@ericpaulsen ericpaulsen added docs Area: coder.com/docs cli Area: CLI labels Aug 23, 2023
@ericpaulsen ericpaulsen self-assigned this Aug 23, 2023
@bpmct
Copy link
Member

bpmct commented Aug 23, 2023

@deansheather can you review? want to make sure all of these flags are active

@bpmct bpmct removed their request for review August 23, 2023 19:38
@matifali
Copy link
Member

Hi @ericpaulsen these are auto generated docs and will be overwritten when make gen is run.
You should update the respective.go files in CLI directory

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the respective go files in CLI directory and then do make gen and make update-golden-files

@ericpaulsen ericpaulsen dismissed matifali’s stale review August 24, 2023 16:27

I've run the make commands requested.

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can you revet changes to type script files?

@ericpaulsen ericpaulsen merged commit 91f900e into main Aug 25, 2023
@ericpaulsen ericpaulsen deleted the ttl-docs branch August 25, 2023 17:39
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cli Area: CLI docs Area: coder.com/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants