chore: rename locked to dormant #9290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The following columns have been updated: - workspace.locked_at -> dormant_at - template.inactivity_ttl -> time_til_dormant - template.locked_ttl -> time_til_dormant_autodelete This change has also been reflected in the SDK.
11eca65 to
581ae4d
Compare
kylecarbs
approved these changes
Aug 24, 2023
matifali
reviewed
Aug 24, 2023
| @@ -134,7 +134,7 @@ func (r *RootCmd) templateCreate() *clibase.Cmd { | |||
| VersionID: job.ID, | |||
| DefaultTTLMillis: ptr.Ref(defaultTTL.Milliseconds()), | |||
| FailureTTLMillis: ptr.Ref(failureTTL.Milliseconds()), | |||
| InactivityTTLMillis: ptr.Ref(inactivityTTL.Milliseconds()), | |||
| TimeTilDormantMillis: ptr.Ref(inactivityTTL.Milliseconds()), | |||
There was a problem hiding this comment.
Suggested change
| TimeTilDormantMillis: ptr.Ref(inactivityTTL.Milliseconds()), | |
| TimeTilDormantMillis: ptr.Ref(timeTilDormant.Milliseconds()), |
I am not sure, but should this be renamed too?
There was a problem hiding this comment.
Probably but it's just a local variable and they mean the same thing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following columns have been updated:
Theses changes have also been reflected in the SDK.
A route has been updated from
/workspaces/<id>/lockto/workspaces/<id>/dormant