Skip to content

docs: incompatibility in parameter options for workspace builds #9297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Aug 24, 2023

Related: #9163

This PR adds to the docs a short paragraph about possible incompatibility in parameter options.

@mtojek mtojek self-assigned this Aug 24, 2023
@mtojek mtojek requested review from johnstcn and bpmct August 24, 2023 08:52
@mtojek mtojek marked this pull request as ready for review August 24, 2023 08:52
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding an example, otherwise LGTM 👍

@mtojek
Copy link
Member Author

mtojek commented Aug 24, 2023

Actually, I tried to come up with something, but the truth is that Coder will just show popup/CLI-select if it can't figure out the value. The syntax stays the same, so I didn't come up with an example.

I can add something if you have any ideas.

EDIT:

I will merge this one, we can always follow up here.

@mtojek mtojek merged commit 52ea233 into main Aug 24, 2023
@mtojek mtojek deleted the 9163-docs branch August 24, 2023 09:05
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants