Skip to content

chore: revert nix-related CI changes #9321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2023
Merged

chore: revert nix-related CI changes #9321

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91f4d1b
chore: revert nix-related CI changes
sreya Aug 25, 2023
d7a917b
make gen
sreya Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: revert nix-related CI changes 
- Reverts using nix to run CI-dependencies.
- Running 'make gen' in a dogfood workspace resulted in inconsistent
  results for protobuf-related files making it difficult to pass CI.
  This PR imports the minimum changes necessary to make CI compatible
  with dogfood.
  • Loading branch information
@sreya
sreya committed Aug 25, 2023
commit 91f4d1b126d64dcd14814c9aa3b5be10c7c3307f
53 changes: 43 additions & 10 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,14 +169,35 @@ jobs:
with:
fetch-depth: 1

- name: Install Nix
uses: DeterminateSystems/nix-installer-action@v4
- name: Setup Node
uses: ./.github/actions/setup-node

- name: Setup Go
uses: ./.github/actions/setup-go

- name: Run the Magic Nix Cache
uses: DeterminateSystems/magic-nix-cache-action@v2
- name: Setup sqlc
uses: ./.github/actions/setup-sqlc

- name: go install tools
run: |
go install google.golang.org/protobuf/cmd/protoc-gen-go@v1.30
go install storj.io/drpc/cmd/protoc-gen-go-drpc@v0.0.33
go install golang.org/x/tools/cmd/goimports@latest
go install github.com/mikefarah/yq/v4@v4.30.6
go install github.com/golang/mock/mockgen@v1.6.0

- name: Install Protoc
run: |
mkdir -p /tmp/proto
pushd /tmp/proto
curl -L -o protoc.zip https://github.com/protocolbuffers/protobuf/releases/download/v23.3/protoc-23.3-linux-x86_64.zip
unzip protoc.zip
cp -r ./bin/* /usr/local/bin
cp -r ./include /usr/local/bin/include
popd

- name: make gen
run: "nix-shell --command 'make --output-sync -j -B gen'"
run: "make --output-sync -j -B gen"

- name: Check for unstaged files
run: ./scripts/check_unstaged.sh
Expand Down Expand Up @@ -508,15 +529,27 @@ jobs:
- name: Setup Terraform
uses: ./.github/actions/setup-tf

- name: Install Nix
uses: DeterminateSystems/nix-installer-action@v4
- name: go install tools
run: |
go install google.golang.org/protobuf/cmd/protoc-gen-go@v1.30
go install storj.io/drpc/cmd/protoc-gen-go-drpc@v0.0.33
go install golang.org/x/tools/cmd/goimports@latest
go install github.com/mikefarah/yq/v4@v4.30.6
go install github.com/golang/mock/mockgen@v1.6.0

- name: Run the Magic Nix Cache
uses: DeterminateSystems/magic-nix-cache-action@v2
- name: Install Protoc
run: |
mkdir -p /tmp/proto
pushd /tmp/proto
curl -L -o protoc.zip https://github.com/protocolbuffers/protobuf/releases/download/v23.3/protoc-23.3-linux-x86_64.zip
unzip protoc.zip
cp -r ./bin/* /usr/local/bin
cp -r ./include /usr/local/bin/include
popd

- name: Build
run: |
nix-shell --command 'make -B site/out/index.html'
make -B site/out/index.html

- run: pnpm playwright:install
working-directory: site
Expand Down