Skip to content

fix: fix test flake introduced by #9264 #9330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 25, 2023
Merged

fix: fix test flake introduced by #9264 #9330

merged 5 commits into from
Aug 25, 2023

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Aug 25, 2023 •
edited
Loading

Missed one!

@spikecurtis
Fix test flake introduced by #9264
8903040 
Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis spikecurtis changed the title Fix test flake introduced by #9264 fix: fix test flake introduced by #9264 Aug 25, 2023
johnstcn
johnstcn previously approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@spikecurtis
change check to match suffix
ee0636a 
Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis spikecurtis requested a review from johnstcn August 25, 2023 09:26
@spikecurtis spikecurtis enabled auto-merge (squash) August 25, 2023 09:26
@johnstcn
Copy link
Member

Filed #9331 for test-go-pg flake

@spikecurtis
Ignore error logs on uncanceled build
b4d7968 
Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis
Copy link
Contributor Author

Fixes #9331

@spikecurtis
ignore error logs in Test_Runner/CleanupPendingBuild
52db2ce 
Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis
accept canceled in Test_Runner/CleanupPendingBuild
2d3bd03 
Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis spikecurtis merged commit e7a231e into main Aug 25, 2023
@spikecurtis spikecurtis deleted the spike/fix-templateversions_test branch August 25, 2023 10:48
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spikecurtis @johnstcn