diff --git a/site/src/components/DeploySettingsLayout/OptionsTable.tsx b/site/src/components/DeploySettingsLayout/OptionsTable.tsx index b573d41b5505b..aef26610712ab 100644 --- a/site/src/components/DeploySettingsLayout/OptionsTable.tsx +++ b/site/src/components/DeploySettingsLayout/OptionsTable.tsx @@ -12,7 +12,6 @@ import { OptionValue, } from "components/DeploySettingsLayout/Option" import { FC } from "react" -import { DisabledBadge } from "./Badges" import { intervalToDuration, formatDuration } from "date-fns" const OptionsTable: FC<{ @@ -21,7 +20,7 @@ const OptionsTable: FC<{ const styles = useStyles() if (options.length === 0) { - return + return

No options to configure

} return ( diff --git a/site/src/pages/DeploySettingsPage/SecuritySettingsPage/SecuritySettingsPageView.tsx b/site/src/pages/DeploySettingsPage/SecuritySettingsPage/SecuritySettingsPageView.tsx index 3e5da55fb9f78..aad2743fb206a 100644 --- a/site/src/pages/DeploySettingsPage/SecuritySettingsPage/SecuritySettingsPageView.tsx +++ b/site/src/pages/DeploySettingsPage/SecuritySettingsPage/SecuritySettingsPageView.tsx @@ -23,66 +23,70 @@ export const SecuritySettingsPageView = ({ options: options, featureAuditLogEnabled, featureBrowserOnlyEnabled, -}: SecuritySettingsPageViewProps): JSX.Element => ( - <> - -
-
+}: SecuritySettingsPageViewProps): JSX.Element => { + const tlsOptions = options.filter((o) => + deploymentGroupHasParent(o.group, "TLS"), + ) - -
+ return ( + <> + +
+
-
-
+ +
- - {featureAuditLogEnabled ? : } - - -
+
+
-
-
+ + {featureAuditLogEnabled ? : } + + +
- - {featureBrowserOnlyEnabled ? : } - - -
+
+
-
-
+ + {featureBrowserOnlyEnabled ? : } + + +
- - deploymentGroupHasParent(o.group, "TLS"), - )} - /> -
-
- -) + {tlsOptions.length > 0 && ( +
+
+ + +
+ )} +
+ + ) +} diff --git a/site/src/pages/DeploySettingsPage/UserAuthSettingsPage/UserAuthSettingsPageView.tsx b/site/src/pages/DeploySettingsPage/UserAuthSettingsPage/UserAuthSettingsPageView.tsx index a1c01adefcd28..1bf89edea3c2b 100644 --- a/site/src/pages/DeploySettingsPage/UserAuthSettingsPage/UserAuthSettingsPageView.tsx +++ b/site/src/pages/DeploySettingsPage/UserAuthSettingsPage/UserAuthSettingsPageView.tsx @@ -19,56 +19,59 @@ export type UserAuthSettingsPageViewProps = { export const UserAuthSettingsPageView = ({ options, -}: UserAuthSettingsPageViewProps): JSX.Element => ( - <> - -
-
+}: UserAuthSettingsPageViewProps): JSX.Element => { + const oidcEnabled = Boolean( + useDeploymentOptions(options, "OIDC Client ID")[0].value, + ) + const githubEnabled = Boolean( + useDeploymentOptions(options, "OAuth2 GitHub Client ID")[0].value, + ) -
+ return ( + <> + +
+
- - {useDeploymentOptions(options, "OIDC Client ID")[0].value ? ( - - ) : ( - - )} - +
+ + {oidcEnabled ? : } - - deploymentGroupHasParent(o.group, "OIDC"), + {oidcEnabled && ( + + deploymentGroupHasParent(o.group, "OIDC"), + )} + /> )} - /> -
+
-
-
+
+
- - {useDeploymentOptions(options, "OAuth2 GitHub Client ID")[0].value ? ( - - ) : ( - - )} - + + {githubEnabled ? : } + - - deploymentGroupHasParent(o.group, "GitHub"), + {githubEnabled && ( + + deploymentGroupHasParent(o.group, "GitHub"), + )} + /> )} - /> -
- - -) +
+
+ + ) +}