Skip to content

refactor(coderd/httpapi): remove database, dbauthz and rbac imports #9481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2023
Merged

refactor(coderd/httpapi): remove database, dbauthz and rbac imports #9481

merged 2 commits into from
Sep 4, 2023

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Sep 1, 2023

Ref: #9380

No size change (yet), this prevents the agent http API from pulling database and parts of coderd.

❯ make build/coder-slim_linux_amd64
/home/coder/src/coder/coder/build/coder-slim_2.1.4-devel+2baf3504a_linux_amd64

❯ ls -lha /home/coder/src/coder/coder/build/coder-slim_2.1.4-devel+2baf3504a_linux_amd64
-rwxr-xr-x 2 coder coder 70M Sep  1 11:28 /home/coder/src/coder/coder/build/coder-slim_2.1.4-devel+2baf3504a_linux_amd64*

@mafredri mafredri self-assigned this Sep 1, 2023
@mafredri mafredri requested a review from Emyrk September 1, 2023 11:29
@mafredri mafredri force-pushed the mafredri/refactor-coderd-httpapi branch from 2baf350 to c67c96e Compare September 1, 2023 11:32
@mafredri mafredri force-pushed the mafredri/refactor-coderd-httpapi branch from c67c96e to 2aa7372 Compare September 1, 2023 11:49
@mafredri mafredri mentioned this pull request Sep 4, 2023
Closed
mafredri added a commit that referenced this pull request Sep 4, 2023
@mafredri
refactor(coderd/database): generate dbresetpw with queries for reset-…
0a61ba8 
…password command

This change removes 1 MB from the slim binary, and combined with the
following PRs: #9481, #9506, #9508, #9517, a total of 4 MB.

Ref: #9380
@mafredri mafredri mentioned this pull request Sep 4, 2023
Merged
mafredri added a commit that referenced this pull request Sep 4, 2023
@mafredri
refactor(cli)!: remove reset-password from slim binary
9c959e6 
This is an alternative approach to #9519 and removes 2 MB instead of 1
MB (1.2 MB accounted for by embedded migration SQL files).

Combined with #9481, #9506, #9508, #9517, a total of 5 MB is removed.

Ref: #9380
mafredri added a commit that referenced this pull request Sep 4, 2023
@mafredri
refactor(cli)!: remove reset-password from slim binary (#9520)
d211594 
This is an alternative approach to #9519 and removes 2 MB instead of 1
MB (1.2 MB accounted for by embedded migration SQL files).

Combined with #9481, #9506, #9508, #9517, a total of 5 MB is removed.

Ref: #9380
@mafredri mafredri merged commit 6fc1f52 into main Sep 4, 2023
@mafredri mafredri deleted the mafredri/refactor-coderd-httpapi branch September 4, 2023 16:39
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@Emyrk Emyrk Awaiting requested review from Emyrk

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @kylecarbs