Skip to content

fix: use $coder_version instead of hardcoded version in release script #9539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2023
Merged

fix: use $coder_version instead of hardcoded version in release script #9539

merged 2 commits into from
Sep 5, 2023

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Sep 5, 2023

Accidentally always pulling the checksums for 2.1.4 :^) oops

@aslilac aslilac added the hotfix label Sep 5, 2023
@aslilac aslilac requested a review from deansheather September 5, 2023 23:01
cdr-bot[bot]
cdr-bot bot approved these changes Sep 5, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@aslilac aslilac mentioned this pull request Sep 5, 2023
Merged
@aslilac aslilac merged commit 2849895 into main Sep 5, 2023
@aslilac aslilac deleted the fix-release-workflow branch September 5, 2023 23:30
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2023
@matifali
Copy link
Member

matifali commented Sep 5, 2023 •
edited
Loading

You may also use @cdrci cdrci@coder.com as the commit author.
Here:

coder/.github/workflows/release.yaml

Lines 351 to 354 in 2849895

# Setup Git
git config --global user.email "ci@coder.com"
git config --global user.name "Coder CI"
git config --global credential.helper "store"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

@deansheather deansheather Awaiting requested review from deansheather

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aslilac @matifali