WIP

coder · mtojek · Sep 11, 2023 · Sep 5, 2023 · Sep 6, 2023 · Sep 6, 2023
commit 85a74cdc2f8f140920ccf96192e64f7dfee2298b
diff --git a/provisioner/terraform/provision.go b/provisioner/terraform/provision.go
@@ -18,6 +18,8 @@ import (
 	"github.com/coder/terraform-provider-coder/provider"
 )
 
+const staleTerraformPluginRetention = 30 * 24 * time.Hour
+
 func (s *server) setupContexts(parent context.Context, canceledOrComplete <-chan struct{}) (
 	ctx context.Context, cancel func(), killCtx context.Context, kill func(),
 ) {
@@ -301,8 +303,11 @@ func cleanStaleTerraformPlugins(ctx context.Context, cachePath string, now time.
 		if err != nil {
 			return xerrors.Errorf("unable to evaluate latest access time for directory %q: %w", pluginPath, err)
 		}
+
+		if accessTime.Add(staleTerraformPluginRetention).Before(now) {
+			stalePlugins = append(stalePlugins, pluginPath)
+		}
 	}
-	// TODO
 
 	// Remove stale plugins
 	// TODO
@@ -314,5 +319,5 @@ func cleanStaleTerraformPlugins(ctx context.Context, cachePath string, now time.
 }
 
 func latestAccessTime(path string) (time.Time, error) {
-
+	// TODO
 }
diff --git a/provisionersdk/session.go b/provisionersdk/session.go
@@ -23,8 +23,8 @@ const (
 	// ReadmeFile is the location we look for to extract documentation from template versions.
 	ReadmeFile = "README.md"
 
-	sessionDirPrefix          = "Session"
-	staleSessionDaysThreshold = 7 * 24 * time.Hour
+	sessionDirPrefix      = "Session"
+	staleSessionRetention = 7 * 24 * time.Hour
 )
 
 // protoServer is a wrapper that translates the dRPC protocol into a Session with method calls into the Server.
@@ -347,7 +347,7 @@ func cleanStaleSessions(ctx context.Context, workDirectory string, now time.Time
 			}
 
 			timeSpec := times.Get(fi)
-			if timeSpec.AccessTime().Add(staleSessionDaysThreshold).After(now) {
+			if timeSpec.AccessTime().Add(staleSessionRetention).After(now) {
 				continue
 			}