Skip to content

refactor: improve flag interpretation for install.sh #9554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 6, 2023
Merged

refactor: improve flag interpretation for install.sh #9554

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0cf437e
refactor: improve installation method detection
aslilac Sep 6, 2023
441719c
detect standalone path conflicts, better defaults
aslilac Sep 6, 2023
e27f44b
detect homebrew conflicts
aslilac Sep 6, 2023
0d6f08d
documentation!
aslilac Sep 6, 2023
30df5a7
🧼
aslilac Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
detect homebrew conflicts
  • Loading branch information
@aslilac
aslilac committed Sep 6, 2023
commit e27f44b125d610e29f5520f39b6bb364fac710aa
7 changes: 7 additions & 0 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,13 @@ echo_brew_postinstall() {
return
fi

CODER_COMMAND="$(command -v "coder")"
BREW_PREFIX="$(brew --prefix)"

if [ "$CODER_COMMAND" != "$BREW_PREFIX/bin/coder" ]; then
echo_path_conflict "$CODER_COMMAND" "$BREW_PREFIX"
fi

cath <<EOF
Homebrew formula has been installed.

Expand Down