Refactor UserAuthSettingsPageView stories

coder · BrunoQuaresma · Sep 8, 2023 · Sep 7, 2023 · Sep 7, 2023 · Sep 7, 2023
commit 64ee7323b110a2177a529e75f305c38d22d2b138
diff --git a/site/src/pages/DeploySettingsPage/UserAuthSettingsPage/UserAuthSettingsPageView.stories.tsx b/site/src/pages/DeploySettingsPage/UserAuthSettingsPage/UserAuthSettingsPageView.stories.tsx
@@ -1,10 +1,20 @@
-import { ComponentMeta, Story } from "@storybook/react";
-import {
-  UserAuthSettingsPageView,
-  UserAuthSettingsPageViewProps,
-} from "./UserAuthSettingsPageView";
+import { DeploymentGroup } from "api/types";
+import { UserAuthSettingsPageView } from "./UserAuthSettingsPageView";
+import type { Meta, StoryObj } from "@storybook/react";
 
-export default {
+const oidcGroup: DeploymentGroup = {
+  name: "OIDC",
+  description: "",
+  children: [] as DeploymentGroup[],
+};
+
+const ghGroup: DeploymentGroup = {
+  name: "Networking",
+  description: "",
+  children: [] as DeploymentGroup[],
+};
+
+const meta: Meta<typeof UserAuthSettingsPageView> = {
   title: "pages/UserAuthSettingsPageView",
   component: UserAuthSettingsPageView,
   args: {
@@ -13,91 +23,101 @@ export default {
         name: "OIDC Client ID",
         description: "Client ID to use for Login with OIDC.",
         value: "1234",
-        group: {
-          name: "OIDC",
-        },
+        group: oidcGroup,
+        flag: "oidc",
+        flag_shorthand: "o",
+        hidden: false,
       },
       {
         name: "OIDC Allow Signups",
         description: "Whether new users can sign up with OIDC.",
         value: true,
-        group: {
-          name: "OIDC",
-        },
+        group: oidcGroup,
+        flag: "oidc",
+        flag_shorthand: "o",
+        hidden: false,
       },
       {
         name: "OIDC Email Domain",
         description:
           "Email domains that clients logging in with OIDC must match.",
         value: "@coder.com",
-        group: {
-          name: "OIDC",
-        },
+        group: oidcGroup,
+        flag: "oidc",
+        flag_shorthand: "o",
+        hidden: false,
       },
       {
         name: "OIDC Issuer URL",
         description: "Issuer URL to use for Login with OIDC.",
         value: "https://coder.com",
-        group: {
-          name: "OIDC",
-        },
+        group: oidcGroup,
+        flag: "oidc",
+        flag_shorthand: "o",
+        hidden: false,
       },
       {
         name: "OIDC Scopes",
         description: "Scopes to grant when authenticating with OIDC.",
         value: ["idk"],
-        group: {
-          name: "OIDC",
-        },
+        group: oidcGroup,
+        flag: "oidc",
+        flag_shorthand: "o",
+        hidden: false,
       },
       {
         name: "OAuth2 GitHub Client ID",
         description: "Client ID for Login with GitHub.",
         value: "1224",
-        group: {
-          name: "GitHub",
-        },
+        group: ghGroup,
+        flag: "oidc",
+        flag_shorthand: "o",
+        hidden: false,
       },
       {
         name: "OAuth2 GitHub Allow Signups",
         description: "Whether new users can sign up with GitHub.",
         value: true,
-        group: {
-          name: "GitHub",
-        },
+        group: ghGroup,
+        flag: "oidc",
+        flag_shorthand: "o",
+        hidden: false,
       },
       {
         name: "OAuth2 GitHub Enterprise Base URL",
         description:
           "Base URL of a GitHub Enterprise deployment to use for Login with GitHub.",
         value: "https://google.com",
-        group: {
-          name: "GitHub",
-        },
+        group: ghGroup,
+        flag: "oidc",
+        flag_shorthand: "o",
+        hidden: false,
       },
       {
         name: "OAuth2 GitHub Allowed Orgs",
         description:
           "Organizations the user must be a member of to Login with GitHub.",
         value: true,
-        group: {
-          name: "GitHub",
-        },
+        group: ghGroup,
+        flag: "oidc",
+        flag_shorthand: "o",
+        hidden: false,
       },
       {
         name: "OAuth2 GitHub Allowed Teams",
         description:
           "Teams inside organizations the user must be a member of to Login with GitHub. Structured as: <organization-name>/<team-slug>.",
         value: true,
-        group: {
-          name: "GitHub",
-        },
+        group: ghGroup,
+        flag: "oidc",
+        flag_shorthand: "o",
+        hidden: false,
       },
     ],
   },
-} as ComponentMeta<typeof UserAuthSettingsPageView>;
+};
+
+export default meta;
+type Story = StoryObj<typeof UserAuthSettingsPageView>;
 
-const Template: Story<UserAuthSettingsPageViewProps> = (args) => (
-  <UserAuthSettingsPageView {...args} />
-);
-export const Page = Template.bind({});
+export const Page: Story = {};