fix: Rename coder to sshd on Windows for VS Code Remote support
#974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, VS Code Remote requires a parent process of the executing shell to be named sshd, otherwise it fails. See: microsoft/vscode-remote-release#5699
Codecov Report
@@ Coverage Diff @@
## main #974 +/- ##
==========================================
+ Coverage 66.70% 66.76% +0.06%
==========================================
Files 241 241
Lines 14577 14577
Branches 115 115
==========================================
+ Hits 9724 9733 +9
+ Misses 3867 3865 -2
+ Partials 986 979 -7
Continue to review full report at Codecov.
|
|
Waiting for us to be open-sourced and someone to ask why the heck we call ourselves |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, VS Code Remote requires a parent process of the
executing shell to be named sshd, otherwise it fails. See:
microsoft/vscode-remote-release#5699