feat(coderd/httpmw): log start timestamp for http requests
#9776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Sep 19, 2023
coderd/httpmw/logger.go
Outdated
| // actually logging the request. This can also be useful when | ||
| // filtering logs that started at a certain time (compared to | ||
| // trying to compute the value). | ||
| slog.F("start_timestamp", start), |
There was a problem hiding this comment.
nit: _timestamp indicates a UNIX timestamp in milliseconds to me. If we're just logging a string, just name it start.
There was a problem hiding this comment.
I can make the change, but I don't feel that timestamp universally refers to UNIX timestamps. A unix timestamp is just one representation for a timestamp (Timestamp examples).
There was a problem hiding this comment.
This is just me, and maybe I'm the odd one out here :-)
johnstcn
approved these changes
Sep 19, 2023
242a550 to
8869937
Compare
start timestamp for http requests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a slog field,
start_timestampstartthat will give us a definitive source of truth for the request timestamp.Having this would've been helpful in debugging #9729 to eliminate a potential, but unlikely, order of events (where the goroutine would be held up, resulting in a log that may have a timestamp later than one would expect).