From 42886afe75f64a56a4ab4d406015fcd9bd26c064 Mon Sep 17 00:00:00 2001 From: BrunoQuaresma Date: Wed, 20 Sep 2023 17:47:33 +0000 Subject: [PATCH 1/3] Fix connection warning --- site/src/pages/TerminalPage/TerminalPage.test.tsx | 3 +++ 1 file changed, 3 insertions(+) diff --git a/site/src/pages/TerminalPage/TerminalPage.test.tsx b/site/src/pages/TerminalPage/TerminalPage.test.tsx index b5659e53b7dbd..f11424f6f48ae 100644 --- a/site/src/pages/TerminalPage/TerminalPage.test.tsx +++ b/site/src/pages/TerminalPage/TerminalPage.test.tsx @@ -67,6 +67,9 @@ describe("TerminalPage", () => { const spy = jest .spyOn(API, "getWorkspaceByOwnerAndName") .mockResolvedValue(MockWorkspace); + new WS( + `ws://localhost/api/v2/workspaceagents/${MockWorkspaceAgent.id}/pty`, + ); await renderTerminal( `/${MockUser.username}/${MockWorkspace.name}/terminal`, ); From d922a56752ccb743c2854afa697ed5e23250c6e4 Mon Sep 17 00:00:00 2001 From: BrunoQuaresma Date: Wed, 20 Sep 2023 17:49:45 +0000 Subject: [PATCH 2/3] Fix connection close --- site/src/pages/TerminalPage/TerminalPage.test.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/site/src/pages/TerminalPage/TerminalPage.test.tsx b/site/src/pages/TerminalPage/TerminalPage.test.tsx index f11424f6f48ae..e3ceb5b6318fe 100644 --- a/site/src/pages/TerminalPage/TerminalPage.test.tsx +++ b/site/src/pages/TerminalPage/TerminalPage.test.tsx @@ -67,7 +67,7 @@ describe("TerminalPage", () => { const spy = jest .spyOn(API, "getWorkspaceByOwnerAndName") .mockResolvedValue(MockWorkspace); - new WS( + const ws = new WS( `ws://localhost/api/v2/workspaceagents/${MockWorkspaceAgent.id}/pty`, ); await renderTerminal( @@ -80,6 +80,7 @@ describe("TerminalPage", () => { ); }); spy.mockRestore(); + ws.close(); }); it("shows an error if fetching workspace fails", async () => { From 66cdb3d88dcf14c092e89cfab996db18510d758d Mon Sep 17 00:00:00 2001 From: BrunoQuaresma Date: Wed, 20 Sep 2023 18:01:39 +0000 Subject: [PATCH 3/3] Increase timeout for terminal --- site/src/pages/TerminalPage/TerminalPage.test.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/src/pages/TerminalPage/TerminalPage.test.tsx b/site/src/pages/TerminalPage/TerminalPage.test.tsx index e3ceb5b6318fe..dae0cf5e85efa 100644 --- a/site/src/pages/TerminalPage/TerminalPage.test.tsx +++ b/site/src/pages/TerminalPage/TerminalPage.test.tsx @@ -58,7 +58,7 @@ const expectTerminalText = (container: HTMLElement, text: string) => { } expect(row.textContent).toContain(text); }, - { timeout: 3_000 }, + { timeout: 5_000 }, ); };