From cf22b74b2c9b4267cc1d51ec9923003b14da3015 Mon Sep 17 00:00:00 2001 From: Muhammad Atif Ali Date: Thu, 21 Sep 2023 18:05:58 +0300 Subject: [PATCH 1/2] docs: update VS Code Web docs --- docs/ides/web-ides.md | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/docs/ides/web-ides.md b/docs/ides/web-ides.md index 1cccc8e7ba9d6..9b3f29c163b9c 100644 --- a/docs/ides/web-ides.md +++ b/docs/ides/web-ides.md @@ -120,7 +120,7 @@ resource "coder_app" "code-server" { display_name = "code-server" url = "http://localhost:13337/?folder=/home/coder" icon = "/icon/code.svg" - subdomain = true + subdomain = false healthcheck { url = "http://localhost:13337/healthz" @@ -159,21 +159,15 @@ resource "coder_agent" "main" { You also need to add a `coder_app` resource for this. ```hcl -# VS Code Server -resource "coder_app" "vscode-server" { - agent_id = coder_agent.coder.id - slug = "vscode-server" - display_name = "VS Code Server" - icon = "/icon/code.svg" - url = "http://localhost:13338?folder=/home/coder" - subdomain = false - share = "owner" - - healthcheck { - url = "http://localhost:13338/healthz" - interval = 3 - threshold = 10 - } +# VS Code Web +resource "coder_app" "vscode-web" { + agent_id = coder_agent.coder.id + slug = "vscode-web" + display_name = "VS Code Web" + icon = "/icon/code.svg" + url = "http://localhost:13338 + subdomain = true # VS Code Web does currently does not work with a subpath https://github.com/microsoft/vscode/issues/192947 + share = "owner" } ``` From 9d387c932a68f8d5ccd07a0d3a2cc04f6971d0d8 Mon Sep 17 00:00:00 2001 From: Muhammad Atif Ali Date: Thu, 21 Sep 2023 18:14:43 +0300 Subject: [PATCH 2/2] add back folder --- docs/ides/web-ides.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/ides/web-ides.md b/docs/ides/web-ides.md index 9b3f29c163b9c..ca5463e5b91b6 100644 --- a/docs/ides/web-ides.md +++ b/docs/ides/web-ides.md @@ -165,7 +165,7 @@ resource "coder_app" "vscode-web" { slug = "vscode-web" display_name = "VS Code Web" icon = "/icon/code.svg" - url = "http://localhost:13338 + url = "http://localhost:13338?folder=/home/coder" subdomain = true # VS Code Web does currently does not work with a subpath https://github.com/microsoft/vscode/issues/192947 share = "owner" }