Skip to content

refactor(scaletest/terraform): break up infra creation and k8s resource provisioning #9824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 22, 2023
Merged

refactor(scaletest/terraform): break up infra creation and k8s resource provisioning #9824

merged 5 commits into from
Sep 22, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Sep 22, 2023 •
edited
Loading

Relates to #9568

This is a precursor to removing all of the null_resource hacks when provisioning k8s resources.

@johnstcn johnstcn requested review from mafredri and mtojek September 22, 2023 13:45
@johnstcn johnstcn self-assigned this Sep 22, 2023
mtojek
mtojek approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cleaner IMHO :) I will leave the final 👍 to Mathias.

mafredri
mafredri approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@johnstcn johnstcn merged commit a1f3a6b into main Sep 22, 2023
@johnstcn johnstcn deleted the cj/refactor-scaletest-terraform branch September 22, 2023 14:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@mtojek mtojek mtojek approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnstcn @mafredri @mtojek