feat: expose application name via Appearance API #9886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
One thing I do notice (which is more of a general issue with our API) is that we often interpret empty values as "unset" on the backend, which can lead to potential confusing when handling update queries (e.g. is {"applicationName: "foo"} going to unset the logo?)
I don't see this as being in scope of this PR though.
This is how I understand it too, so the only possible solution would be downloading the latest state, modifying it, and uploading it back. |
mafredri
approved these changes
Sep 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #8395
This PR exposes
application_namebehind/appearanceand stores its value in the database. It improves error reporting around appearance to be more consistent with the rest of coderd API.