Skip to content

feat(scaletest/terraform): add cert-manager, otel, and TLS #9894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

johnstcn
Copy link
Member

Fixes #9568

  • Adds cert-manager deployment
  • Adds otel-collector deployment
  • Adds logic to create TLS cert for Coder given required Cloudflare credentials

@johnstcn johnstcn self-assigned this Sep 27, 2023
@johnstcn johnstcn requested review from mafredri and mtojek September 27, 2023 16:22
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

values = [<<EOF
installCRDs: true
EOF
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't seen this syntax before, is it one string inside the values array? 🤔

I think you can do it this way too:

  set {
    name  = "installCRDs"
    value = true
  }

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep this is the simplest way to set multiple values as one, you can essentially paste in YAML with variable interpolation. I think it's the most readable of the available options, especially with large charts that have lots of options!

@johnstcn johnstcn merged commit 72e8f88 into main Sep 27, 2023
@johnstcn johnstcn deleted the cj/scaletest-terraform-additions branch September 27, 2023 16:41
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scaletest: address drift in terraform config
2 participants