Skip to content

feat(site): use custom application name #9902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 28, 2023
Merged

feat(site): use custom application name #9902

merged 4 commits into from
Sep 28, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Sep 28, 2023 •
edited
Loading

Resolves: #8395

Screenshot 2023-09-28 at 15 38 52

Changes:

  • Adjust login form to consume application_name and logo_url
  • Add "Application name" field to "appearance" API

@mtojek mtojek self-assigned this Sep 28, 2023
@mtojek mtojek mentioned this pull request Sep 28, 2023
Closed
@mtojek mtojek changed the title site: use custom application name feat(site): use custom application name Sep 28, 2023
@mtojek mtojek marked this pull request as ready for review September 28, 2023 13:50
Parkreiner
Parkreiner reviewed Sep 28, 2023
View reviewed changes
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly have one question about the use of querySelector, but overall, I think this looks good.

@Parkreiner Parkreiner self-requested a review September 28, 2023 16:20
Parkreiner
Parkreiner approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally pressed the wrong button at first, but I'm approving

@mtojek mtojek merged commit 305556f into main Sep 28, 2023
@mtojek mtojek deleted the 8395-render-custom-text-logo branch September 28, 2023 16:23
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
@matifali
Copy link
Member

@mtojek where does the Foobarz display?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Parkreiner Parkreiner Parkreiner approved these changes

@BrunoQuaresma BrunoQuaresma Awaiting requested review from BrunoQuaresma

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom logo and text in login screen
3 participants
@mtojek @matifali @Parkreiner