Skip to content

feat(site): use custom application name #9902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 28, 2023
Merged

feat(site): use custom application name #9902

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5173c1
site: use custom application name
mtojek Sep 28, 2023
c9aaea1
stories
mtojek Sep 28, 2023
a623f2b
Fix: a11y
mtojek Sep 28, 2023
4b80721
fix: use document.head
mtojek Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix: a11y
  • Loading branch information
@mtojek
mtojek committed Sep 28, 2023
commit a623f2b5774dfa7daff12273a1215ff6dab0754d
5 changes: 3 additions & 2 deletions site/src/pages/LoginPage/LoginPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { AuthContext, UnauthenticatedData } from "xServices/auth/authXService";
import { SignInForm } from "./SignInForm";
import { retrieveRedirect } from "utils/redirect";
import { CoderIcon } from "components/Icons/CoderIcon";
import { getLogoURL } from "utils/appearance";
import { getApplicationName, getLogoURL } from "utils/appearance";

export interface LoginPageViewProps {
context: AuthContext;
Expand All @@ -29,11 +29,12 @@ export const LoginPageView: FC<LoginPageViewProps> = ({
// This allows messages to be displayed at the top of the sign in form.
// Helpful for any redirects that want to inform the user of something.
const info = new URLSearchParams(location.search).get("info") || undefined;
const applicationName = getApplicationName();
const logoURL = getLogoURL();
const applicationLogo = logoURL ? (
<div>
<img
alt=""
alt={applicationName}
src={logoURL}
// This prevent browser to display the ugly error icon if the
// image path is wrong or user didn't finish typing the url
Expand Down