update for CredentialModel having a Uri type

spikecurtis · spikecurtis · commit e028b3c34eda · 2025-05-13T09:39:23.000+04:00
diff --git a/App/Services/UriHandler.cs b/App/Services/UriHandler.cs
@@ -140,9 +140,9 @@ private void CheckAuthority(Uri uri, string errTitle)
                 $"Failed to open '{uri.AbsolutePath}' because you are not signed in.");
         }
 
-        // here we assume that the URL is valid since the credentials are marked valid. If not it's an internal error
+        // here we assume that the URL is non-null since the credentials are marked valid. If not it's an internal error
         // and the App will handle catching the exception and logging it.
-        var coderUri = new Uri(credentialModel.CoderUrl!);
+        var coderUri = credentialModel.CoderUrl!;
         if (uri.Authority != coderUri.Authority)
         {
             logger.LogWarning(
diff --git a/Tests.App/Services/UriHandlerTest.cs b/Tests.App/Services/UriHandlerTest.cs
@@ -64,7 +64,7 @@ public void AgentWorkspaceAndCredentialFixtures()
         credentialModel1 = new CredentialModel
         {
             State = CredentialState.Valid,
-            CoderUrl = "https://coder.test",
+            CoderUrl = new Uri("https://coder.test"),
         };
     }
 

Original file line number	Diff line number	Diff line change
`@@ -140,9 +140,9 @@ private void CheckAuthority(Uri uri, string errTitle)`
`140`	`140`	`$"Failed to open '{uri.AbsolutePath}' because you are not signed in.");`
`141`	`141`	`}`
`142`	`142`
`143`		`- // here we assume that the URL is valid since the credentials are marked valid. If not it's an internal error`
	`143`	`+ // here we assume that the URL is non-null since the credentials are marked valid. If not it's an internal error`
`144`	`144`	`// and the App will handle catching the exception and logging it.`
`145`		`- var coderUri = new Uri(credentialModel.CoderUrl!);`
	`145`	`+ var coderUri = credentialModel.CoderUrl!;`
`146`	`146`	`if (uri.Authority != coderUri.Authority)`
`147`	`147`	`{`
`148`	`148`	`logger.LogWarning(`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ public void AgentWorkspaceAndCredentialFixtures()`
`64`	`64`	`credentialModel1 = new CredentialModel`
`65`	`65`	`{`
`66`	`66`	`State = CredentialState.Valid,`
`67`		`- CoderUrl = "https://coder.test",`
	`67`	`+ CoderUrl = new Uri("https://coder.test"),`
`68`	`68`	`};`
`69`	`69`	`}`
`70`	`70`