PR comments

deansheather · deansheather · commit fe567aab41b6 · 2025-03-14T17:25:27.000+10:00
diff --git a/App/Controls/SizedFrame.cs b/App/Controls/SizedFrame.cs
@@ -11,8 +11,11 @@ public class SizedFrameEventArgs : EventArgs
 }
 
 /// <summary>
-///     SizedFrame extends Frame by adding a SizeChanged event. Sadly this is necessary because
-///     Window.Content.SizeChanged doesn't trigger when the Page's content changes.
+///     SizedFrame extends Frame by adding a SizeChanged event, which will be triggered when:
+///       - The contained Page's content's size changes
+///       - We switch to a different page.
+///
+///     Sadly this is necessary because Window.Content.SizeChanged doesn't trigger when the Page's content changes.
 /// </summary>
 public class SizedFrame : Frame
 {
diff --git a/App/Views/TrayWindow.xaml.cs b/App/Views/TrayWindow.xaml.cs
@@ -126,7 +126,7 @@ public void SetRootFrame(Page page)
 
     private void RootFrame_SizeChanged(object sender, SizedFrameEventArgs e)
     {
-        ResizeWindow(e.NewSize.Width);
+        ResizeWindow(e.NewSize.Height);
         MoveWindow();
     }
 

Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,11 @@ public class SizedFrameEventArgs : EventArgs`
`11`	`11`	`}`
`12`	`12`
`13`	`13`	`/// <summary>`
`14`		`-/// SizedFrame extends Frame by adding a SizeChanged event. Sadly this is necessary because`
`15`		`-/// Window.Content.SizeChanged doesn't trigger when the Page's content changes.`
	`14`	`+/// SizedFrame extends Frame by adding a SizeChanged event, which will be triggered when:`
	`15`	`+/// - The contained Page's content's size changes`
	`16`	`+/// - We switch to a different page.`
	`17`	`+///`
	`18`	`+/// Sadly this is necessary because Window.Content.SizeChanged doesn't trigger when the Page's content changes.`
`16`	`19`	`/// </summary>`
`17`	`20`	`public class SizedFrame : Frame`
`18`	`21`	`{`
Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ public void SetRootFrame(Page page)`
`126`	`126`
`127`	`127`	`private void RootFrame_SizeChanged(object sender, SizedFrameEventArgs e)`
`128`	`128`	`{`
`129`		`- ResizeWindow(e.NewSize.Width);`
	`129`	`+ ResizeWindow(e.NewSize.Height);`
`130`	`130`	`MoveWindow();`
`131`	`131`	`}`
`132`	`132`