feat: enabled sign out and animated window resize #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
May 28, 2025
App/Views/TrayWindow.xaml.cs
Outdated
| { | ||
| // Remember where we start | ||
| _lastWindowHeight = AppWindow.Size.Height; | ||
| _resizeInProgress = true; |
There was a problem hiding this comment.
This never gets set back to false AFAIK
There was a problem hiding this comment.
It was a leftover I forgot to clean-up. Initial implementation was using a semaphore to order transactions, but I saw BeginTime allows you to delay enough to order them. I added Skip when user clicks quickly and that resolves all issues.
Added comments for better understanding.
Co-authored-by: Dean Sheather <dean@deansheather.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #96