chore: improve text output for resource check

jawnsy · jawnsy · commit ca8679d64b4e · 2021-09-23T12:37:11.000Z
* Remove the synthetic error and create a failed result manually
* Add the resource, group, and groupVersion in Details, so that
  it will be included in JSON output
diff --git a/internal/checks/kube/resources.go b/internal/checks/kube/resources.go
@@ -4,7 +4,6 @@ import (
 	"context"
 	"fmt"
 
-	"golang.org/x/xerrors"
 	"k8s.io/apimachinery/pkg/runtime/schema"
 
 	"cdr.dev/coder-doctor/internal/api"
@@ -46,14 +45,23 @@ func (k *KubernetesChecker) CheckResources(_ context.Context) []*api.CheckResult
 	}
 
 	for versionReq := range k.reqs.ResourceRequirements {
-		if !resourcesAvailable[*versionReq] {
-			msg := fmt.Sprintf("missing required resource:%q group:%q version:%q", versionReq.Resource, versionReq.Group, versionReq.Version)
-			errResult := api.ErrorResult(checkName, msg, xerrors.New(msg))
-			results = append(results, errResult)
-			continue
+		result := &api.CheckResult{
+			Summary: checkName,
+			Details: map[string]interface{}{
+				"resource":     versionReq.Resource,
+				"group":        versionReq.Group,
+				"groupVersion": versionReq.Version,
+			},
+		}
+
+		if resourcesAvailable[*versionReq] {
+			result.Summary = fmt.Sprintf("Cluster supports %s resource %s", versionReq.Version, versionReq.Resource)
+			result.State = api.StatePassed
+		} else {
+			result.Summary = fmt.Sprintf("Cluster does not support %s resource %s", versionReq.Version, versionReq.Resource)
+			result.State = api.StateFailed
 		}
-		msg := fmt.Sprintf("found required resource:%q group:%q version:%q", versionReq.Resource, versionReq.Group, versionReq.Version)
-		results = append(results, api.PassResult(checkName, msg))
+		results = append(results, result)
 	}
 
 	return results
