From ab9c101d1f58fe8a94228f738faf4fce8a881017 Mon Sep 17 00:00:00 2001
From: Jonathan Yu <jonathan@coder.com>
Date: Thu, 23 Sep 2021 12:38:34 +0000
Subject: [PATCH] chore: add stricter revive linter settings

---
 .golangci.yml | 28 ++++++++++++++++++++++++----
 1 file changed, 24 insertions(+), 4 deletions(-)

diff --git a/.golangci.yml b/.golangci.yml
index a9605f5..d46003c 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -74,6 +74,11 @@ linters-settings:
     ignore-generated-header: true
     severity: warning
     rules:
+      # generates many false positives with constant strings
+      # used to print, or numbers like 0 and 1
+      # - name: add-constant
+      - name: argument-limit
+        arguments: [5]
       - name: atomic
       - name: bare-return
       - name: blank-imports
@@ -81,9 +86,13 @@ linters-settings:
       - name: call-to-gc
       - name: confusing-naming
       - name: confusing-results
+      - name: cognitive-complexity
+        arguments: [40] # TODO: fix code and reduce this
       - name: constant-logical-expr
       - name: context-as-argument
       - name: context-keys-type
+      # seems to be redundant with gocyclo
+      # - name: cyclomatic
       - name: deep-exit
       - name: defer
       - name: dot-imports
@@ -96,25 +105,37 @@ linters-settings:
       - name: error-strings
       - name: errorf
       - name: exported
+      # - name: file-header
       - name: flag-parameter
+      - name: function-result-limit
+        arguments: [3]
+      # - name: function-length
       - name: get-return
       - name: identical-branches
       - name: if-return
-      - name: import-shadowing
       - name: increment-decrement
       - name: indent-error-flow
+      - name: imports-blacklist
+      - name: import-shadowing
+      - name: line-length-limit
+        arguments: [200] # TODO: reduce this
+      # - name: max-public-structs
       - name: modifies-parameter
       - name: modifies-value-receiver
+      - name: nested-structs
       - name: package-comments
       - name: range
-      - name: range-val-address
       - name: range-val-in-closure
+      - name: range-val-address
       - name: receiver-naming
       - name: redefines-builtin-id
       - name: string-of-int
       - name: struct-tag
+      - name: string-format
       - name: superfluous-else
       - name: time-naming
+      - name: var-naming
+      - name: var-declaration
       - name: unconditional-recursion
       - name: unexported-naming
       - name: unexported-return
@@ -123,8 +144,7 @@ linters-settings:
       - name: unreachable-code
       - name: unused-parameter
       - name: unused-receiver
-      - name: var-declaration
-      - name: var-naming
+      - name: useless-break
       - name: waitgroup-by-value
 
 issues: