refactor: abstract logic for better readability

fioan89 · fioan89 · commit 2c7824bf9f71 · 2025-05-02T00:10:36.000+03:00
diff --git a/src/main/kotlin/com/coder/toolbox/CoderRemoteProvider.kt b/src/main/kotlin/com/coder/toolbox/CoderRemoteProvider.kt
@@ -262,9 +262,7 @@ class CoderRemoteProvider(
             // start initialization with the new settings
             this@CoderRemoteProvider.client = restClient
             coderHeaderPage = NewEnvironmentPage(context, context.i18n.pnotr(restClient.url.toString()))
-            environments.update {
-                LoadableState.Loading
-            }
+            environments.showLoadingMessage()
             pollJob = poll(restClient, cli)
         }
     }
@@ -329,11 +327,14 @@ class CoderRemoteProvider(
         context.secrets.rememberMe = true
         this.client = client
         pollJob?.cancel()
+        environments.showLoadingMessage()
+        pollJob = poll(client, cli)
+        goToEnvironmentsPage()
+    }
 
-        environments.update {
+    private fun MutableStateFlow<LoadableState<List<RemoteProviderEnvironment>>>.showLoadingMessage() {
+        this.update {
             LoadableState.Loading
         }
-        pollJob = poll(client, cli)
-        goToEnvironmentsPage()
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -262,9 +262,7 @@ class CoderRemoteProvider(`
`262`	`262`	`// start initialization with the new settings`
`263`	`263`	`this@CoderRemoteProvider.client = restClient`
`264`	`264`	`coderHeaderPage = NewEnvironmentPage(context, context.i18n.pnotr(restClient.url.toString()))`
`265`		`- environments.update {`
`266`		`- LoadableState.Loading`
`267`		`- }`
	`265`	`+ environments.showLoadingMessage()`
`268`	`266`	`pollJob = poll(restClient, cli)`
`269`	`267`	`}`
`270`	`268`	`}`
`@@ -329,11 +327,14 @@ class CoderRemoteProvider(`
`329`	`327`	`context.secrets.rememberMe = true`
`330`	`328`	`this.client = client`
`331`	`329`	`pollJob?.cancel()`
	`330`	`+ environments.showLoadingMessage()`
	`331`	`+ pollJob = poll(client, cli)`
	`332`	`+ goToEnvironmentsPage()`
	`333`	`+ }`
`332`	`334`
`333`		`- environments.update {`
	`335`	`+ private fun MutableStateFlow<LoadableState<List<RemoteProviderEnvironment>>>.showLoadingMessage() {`
	`336`	`+ this.update {`
`334`	`337`	`LoadableState.Loading`
`335`	`338`	`}`
`336`		`- pollJob = poll(client, cli)`
`337`		`- goToEnvironmentsPage()`
`338`	`339`	`}`
`339`	`340`	`}`