impl: improve logging around resource cleanup

fioan89 · fioan89 · commit b396cd3b59e5 · 2025-09-16T00:23:02.000+03:00
Another error reported by JetBrains is a  `RejectedExecutionException` in the rest api client,
and from the stack trace it seems the thread pool in the rest client was at some point shutdown.
I think it is some sort of race condition, some thread calling shutting down the rest api client
while the UI thread still executes polling and user's action. I tried to reproduce the issue with
no success, and so I'm improving the logging around plugin de-initialization in the hope that next
time the sequence of events is more helpful.
diff --git a/src/main/kotlin/com/coder/toolbox/CoderRemoteProvider.kt b/src/main/kotlin/com/coder/toolbox/CoderRemoteProvider.kt
@@ -202,8 +202,10 @@ class CoderRemoteProvider(
      * first page.
      */
     private fun logout() {
+        context.logger.info("Logging out ${client?.me?.username}...")
         WorkspaceConnectionManager.reset()
         close()
+        context.logger.info("User ${client?.me?.username} logged out successfully")
     }
 
     /**
@@ -244,12 +246,16 @@ class CoderRemoteProvider(
             it.cancel()
             context.logger.info("Cancelled workspace poll job ${pollJob.toString()}")
         }
-        client?.close()
+        client?.let {
+            it.close()
+            context.logger.info("REST API client closed and resources released")
+        }
+        client = null
         lastEnvironments.clear()
         environments.value = LoadableState.Value(emptyList())
         isInitialized.update { false }
-        client = null
         CoderCliSetupWizardState.goToFirstStep()
+        context.logger.info("Coder plugin is now closed")
     }
 
     override val svgIcon: SvgIcon =
@@ -317,12 +323,12 @@ class CoderRemoteProvider(
                 uri,
                 shouldDoAutoSetup()
             ) { restClient, cli ->
-                // stop polling and de-initialize resources
+                context.logger.info("Stopping workspace polling and de-initializing resources")
                 close()
                 isInitialized.update {
                     false
                 }
-                // start initialization with the new settings
+                context.logger.info("Starting initialization with the new settings")
                 this@CoderRemoteProvider.client = restClient
                 coderHeaderPage.setTitle(context.i18n.pnotr(restClient.url.toString()))
 
