Tags: coder/coder-jetbrains-toolbox
Tags
fix: access the settings page for the auth. wizard (#105) The Settings menu is only available after we successfully authenticate. This can be somewhat problematic if we want to configure something like coder cli path, or certificate path before doing the authentication. A new "Settings" button at the bottom of the page can now access the Settings page. Toolbox is a bit inflexible with the API because: - I could not find a way to delimit or separate the Settings button from the Back and Sign In/Connect button - we can't put a button or anything else in the top right corner, the traditional place for a settings icon. - resolves #90
fix: hostname and proxy command generation (#95) - latest Coder versions won't accept the SSH connections if proxy command does not include the workspace owner name - for wildcard configuration the ssh config stays the same but the actual hostname provided to the Toolbox will include the workspace owner name For wildcard config: - the ssh config hostname follows the `coder-jetbrains-toolbox-dev.coder.com--*` pattern - the proxy command will have a similar host prefix - the hostname provided to Toolbox follows the `coder-jetbrains-toolbox-dev.coder.com--${ws.ownerName}--${ws.name}.${agent.name}` pattern For non wildcard config: - the ssh config hostname follows the `coder-jetbrains-toolbox--${ws.ownerName}--${ws.name}.${agent.name}--dev.coder.com` pattern - the proxy command will have the username and hostname in the ${ws.ownerName}/${ws.name}.${agent.name} format - the hostname provided to Toolbox follows the `coder-jetbrains-toolbox-dev.coder.com--${ws.ownerName}--${ws.name}.${agent.name}` pattern - resolves #94
fix: token input screen is closed after switching between Toolbox and… … browser (#72) - rough draft to fix UI state management in the authentication flow which today has 3 pages. If user closes Toolbox in any of these three pages (for example to go and copy the token from a browser), then when it comes back in Toolbox does not remember which was the last visible UiPage. - until JetBrains improves Toolbox state management, we can work around the problem by having only one UiPage with three "steps" in it, similar to a wizard. With this approach we can have complete control over the state of the page. - to be noted that I've also looked over two other approaches. The first idea was to manage the stat ourselves, but that didn’t work out as Toolbox doesn’t clearly tell us when the user clicks the Back button vs. when they close the window. So we can’t reliably figure out which page to show when it reopens. - another option was changing the auth flow entirely and adding custom redirect URLs for Toolbox plugins. But that would only work with certain Coder versions, which might not be ideal. - resolves #45