Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Commit 7d70c41

Browse files
committed
comment out integration tests we can't yet clean
1 parent 40ad127 commit 7d70c41

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

ci/integration/envs_test.go

+13-10
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package integration
22

33
import (
44
"context"
5-
"fmt"
65
"regexp"
76
"testing"
87

@@ -38,12 +37,14 @@ func TestEnvsCLI(t *testing.T) {
3837
tcli.StderrEmpty(),
3938
)
4039

40+
// TODO(Faris) : uncomment this when we can safely purge the environments
41+
// the integrations tests would create in the sidecar
4142
// Successfully create environment.
42-
c.Run(ctx, "coder envs create --image "+ubuntuImgID+" test-ubuntu").Assert(t,
43-
tcli.Success(),
44-
// why does flog.Success write to stderr?
45-
tcli.StderrMatches(regexp.QuoteMeta("Successfully created environment \"test-ubuntu\"")),
46-
)
43+
// c.Run(ctx, "coder envs create --image "+ubuntuImgID+" test-ubuntu").Assert(t,
44+
// tcli.Success(),
45+
// // why does flog.Success write to stderr?
46+
// tcli.StderrMatches(regexp.QuoteMeta("Successfully created environment \"test-ubuntu\"")),
47+
// )
4748

4849
// Invalid environment name should fail.
4950
c.Run(ctx, "coder envs create --image "+ubuntuImgID+" this-IS-an-invalid-EnvironmentName").Assert(t,
@@ -52,11 +53,13 @@ func TestEnvsCLI(t *testing.T) {
5253
tcli.StderrMatches(regexp.QuoteMeta("environment name must conform to regex ^[a-z0-9]([a-z0-9-]+)?")),
5354
)
5455

56+
// TODO(Faris) : uncomment this when we can safely purge the environments
57+
// the integrations tests would create in the sidecar
5558
// Successfully provision environment with fractional resource amounts
56-
c.Run(ctx, fmt.Sprintf(`coder envs create -i %s -c 1.2 -m 1.4 non-whole-resource-amounts`, ubuntuImgID)).Assert(t,
57-
tcli.Success(),
58-
tcli.StderrMatches(regexp.QuoteMeta("Successfully created environment \"non-whole-resource-amounts\"")),
59-
)
59+
// c.Run(ctx, fmt.Sprintf(`coder envs create -i %s -c 1.2 -m 1.4 non-whole-resource-amounts`, ubuntuImgID)).Assert(t,
60+
// tcli.Success(),
61+
// tcli.StderrMatches(regexp.QuoteMeta("Successfully created environment \"non-whole-resource-amounts\"")),
62+
// )
6063

6164
// Image does not exist should fail.
6265
c.Run(ctx, "coder envs create --image does-not-exist env-will-not-be-created").Assert(t,

internal/cmd/envs.go

+1
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ func createEnvCommand() *cobra.Command {
139139
Use: "create [flags] [environment-name]",
140140
Short: "create a new environment.",
141141
Args: cobra.ExactArgs(1),
142+
Hidden: true,
142143
Long: "Create a new environment under the active user.",
143144
Example: `
144145
# create a new environment using default resource amounts

0 commit comments

Comments
 (0)